Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 15, 2026

Signed-off-by: Juan Cruz Viotti [email protected]

Signed-off-by: Juan Cruz Viotti <[email protected]>
@augmentcode
Copy link

augmentcode bot commented Jan 15, 2026

🤖 Augment PR Summary

Summary: This PR migrates One’s HTML generation utilities to use the new HTML module provided by Sourcemeta Core.

Changes:

  • Removes the local src/html library (and its unit tests) from One’s build.
  • Bumps the vendored Core dependency to a revision that contains the new HTML module.
  • Adds Core’s HTML component to the vendored Core build configuration and default components list.
  • Introduces Core HTML sources/headers under vendor/core/src/core/html (encoder, escape, elements API).
  • Updates the web generator to include <sourcemeta/core/html.h> and use sourcemeta::core::HTML/HTMLNode.
  • Updates linking so sourcemeta_one_web depends on sourcemeta::core::html instead of sourcemeta::one::html.

Technical Notes: Core’s API uses HTMLAttributes as an ordered vector of key/value pairs (instead of a map), and the escaping function is now sourcemeta::core::html_escape.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

#endif

/// @ingroup html
inline auto raw(std::string html_content) -> HTMLRaw {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raw() emits unescaped HTML verbatim; consider adding an explicit “danger/only trusted input” note here to reduce accidental XSS-style misuse by downstream callers.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants